Alter direct calls to redis using intermediate redis settings #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps up redis_cache version, gets access to redis client used by cache layer
| @@ -223,7 +221,11 @@ def get_anchor(self, request, **kwargs): | |||
| self.throttle_check(request) | |||
|
|
|||
| query = request.GET.get('q', '') | |||
| redis_data = redis_client.keys("*redirects:v4*%s*" % query) | |||
| try: | |||
| redis_client = cache.get_client(None) | |||
There was a problem hiding this comment.
Didn't know get_client was a thing. It doesn't appear to be documented?
There was a problem hiding this comment.
Seems similar to https://docs.djangoproject.com/en/1.8/topics/cache/#django.core.cache.get_cache -- which is deprecated.
There was a problem hiding this comment.
Seems like it should just be using django.core.cache.cache. Seems this code would be dependent on implementation of the redis backend and redis being used as a cache.
There was a problem hiding this comment.
It's exposed from redis_cache. If the cache backend isn't redis, this expects to catch the AttributeError that will be thrown
There was a problem hiding this comment.
Ah, that makes sense. Guess the code depends on redis as it is :)
ericholscher
added a commit
that referenced
this pull request
Oct 30, 2015
Alter direct calls to redis using intermediate redis settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis will be split up into calls to redis cache server and redis celery
server. Instead of calling the intermediate object in settings, use existing
configuration for these two databases.
This bumps the version number for redis_cache, as it's far behind, as well as
the version for redis.